Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-6081 Add-model check when creating a model #1116

Merged

Conversation

alesstimec
Copy link
Collaborator

Description

When creating a model we check that the owner has an add-model permission on the cloud.

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git commit -S --amend --no-edit) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@alesstimec alesstimec force-pushed the can-add-model-check-when-adding-model-01 branch from 25e7483 to 47a3eb6 Compare December 11, 2023 12:37
internal/jimm/model.go Outdated Show resolved Hide resolved
internal/jimm/model_test.go Outdated Show resolved Hide resolved
@alesstimec alesstimec force-pushed the can-add-model-check-when-adding-model-01 branch 2 times, most recently from f35c972 to 15b3062 Compare December 11, 2023 13:59
When creating a model we check that the owner has an add-model permission
on the cloud.
@alesstimec alesstimec force-pushed the can-add-model-check-when-adding-model-01 branch from 15b3062 to 991629a Compare December 11, 2023 14:48
@alesstimec alesstimec merged commit a9dfb57 into canonical:v3 Jan 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants