Add permissions to JWT #1119
Merged
Add permissions to JWT #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesstimec
requested review from
kian99,
ale8k,
babakks and
mina1460
as code owners
kian99
approved these changes
Jan 2, 2024
For certain method calls, we need to add additional permissions to the JWT: e.g. when adding a model, we need to add cloud permission stating that the user has permission to add-model on that cloud.
alesstimec
force-pushed
the
add-permissions-to-jwt
branch
from
3b636f1 to
13f545c
Compare
babakks
approved these changes
Jan 3, 2024
mina1460
approved these changes
Jan 4, 2024
Comment on lines
+125
to
+130
| permissionMap = make(map[string]string, len(permissons)) | ||
| for _, p := range permissons { | ||
| permissionMap[p.resource] = p.relation | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This is smart. I would have sent the map instead of the variadic args and would have ended up constructing the map everywhere and duplicating code. Your way is much smarter. I learned something new today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For certain method calls, we need to add additional permissions to the JWT: e.g. when adding a model, we need to add cloud permission stating that the user has permission to add-model on that cloud.
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers