Refactors dialing #1120
Merged
Refactors dialing #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesstimec
requested review from
kian99,
ale8k,
babakks and
mina1460
as code owners
alesstimec
force-pushed
the
refactor-dialing-01
branch
from
0f383f4 to
0a1d9b3
Compare
Moves the main body of the dial function to the rpc package.
alesstimec
force-pushed
the
refactor-dialing-01
branch
from
0a1d9b3 to
f332379
Compare
mina1460
approved these changes
Jan 3, 2024
babakks
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the main body of the dial function to the rpc package.
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers