Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-6766 implement grant access to service account #1138

Conversation

kian99
Copy link
Contributor

@kian99 kian99 commented Jan 19, 2024

Description

This PR builds on #1136.
This PR implements an GrantServiceAccountAccess method that will enable users to grant other users access to a service account.

Fixes CSS-6766

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Copy link
Collaborator

@alesstimec alesstimec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo all 🍬

internal/jimm/service_account.go Show resolved Hide resolved
internal/jujuapi/service_account.go Outdated Show resolved Hide resolved
internal/jujuapi/service_account.go Show resolved Hide resolved
internal/openfga/user.go Show resolved Hide resolved
@kian99 kian99 force-pushed the CSS-6766-implement-GrantAccessToServiceAccount branch from 282c174 to d0469f1 Compare January 19, 2024 16:45
Copy link
Contributor

@mina1460 mina1460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kian99 kian99 merged commit f70ba71 into canonical:feature-serviceaccounts Jan 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants