Merge latest v3 changes to feature-oidc #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reconfigured realm and client
…reconfigured realm and client
…k/jimm into css-6713/integrate-keycloak
Moving access related logic from jujuapi to jimm.
Refactor the JWKS cache away from the jwk.Cache object which caches an HTTP response and causes JIMM to make an HTTP call to itself. Instead, we use a cache with a TTL and fetch the JWK set from Vault periodically (currently set to 1h) with a frequency much higher than the cache refresh interval.
kian99
requested review from
alesstimec,
ale8k,
babakks and
mina1460
as code owners
alesstimec
approved these changes
Feb 7, 2024
ale8k
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge the latest changes from v3 into
feature-oidc.Includes:
jimm, fromjujuapi.Normally I wouldn't merge the original branch into the feature-branch but it would be beneficial to bring in these changes for the cache system which we can reuse for the OAuth private key. cc @babakks