Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-8226 Vault k8s relation #1197

Merged
merged 5 commits into from
Apr 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .air.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ tmp_dir = "tmp"

[build]
args_bin = []
bin = "./tmp/jimm"
bin = "env $(cat /vault/vault.env | xargs) ./tmp/jimm"
cmd = "go build -gcflags='all=-N -l' -buildvcs=false -o ./tmp/jimm ./cmd/jimmsrv"
delay = 1000
exclude_dir = [".vscode", "assets", "tmp", "vendor", "testdata"]
exclude_file = []
exclude_regex = ["_test.go"]
exclude_unchanged = false
follow_symlink = false
full_bin = "dlv exec --accept-multiclient --log --headless --continue --listen :2345 --api-version 2 ./tmp/jimm"
full_bin = "env $(cat /vault/vault.env | xargs) dlv exec --accept-multiclient --log --headless --continue --listen :2345 --api-version 2 ./tmp/jimm"
include_dir = []
include_ext = ["go", "tpl", "tmpl", "html"]
kill_delay = "0s"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
run: |
touch ./local/vault/approle.json
touch ./local/vault/roleid.txt
touch ./local/vault/vault.env
- name: Create test certs
run: make certs
- name: Start test environment
Expand Down Expand Up @@ -69,6 +70,7 @@ jobs:
run: |
touch ./local/vault/approle.json
touch ./local/vault/roleid.txt
touch ./local/vault/vault.env
- run: go version
- run: go mod vendor
- run: docker compose --profile dev up -d --wait --timestamps
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ certs:
@cd local/traefik/certs; ./certs.sh; cd -

test-env: sysdeps certs
@touch ./local/vault/approle.json && touch ./local/vault/roleid.txt
@touch ./local/vault/approle.json && touch ./local/vault/roleid.txt && touch ./local/vault/vault.env
@docker compose up --force-recreate -d --wait

test-env-cleanup:
@docker compose down -v --remove-orphans

dev-env-setup: sysdeps certs
@touch ./local/vault/approle.json && touch ./local/vault/roleid.txt
@touch ./local/vault/approle.json && touch ./local/vault/roleid.txt && touch ./local/vault/vault.env
@make version/commit.txt && make version/version.txt
@go mod vendor

Expand Down
17 changes: 9 additions & 8 deletions charms/jimm-k8s/charmcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,18 @@ parts:
charm:
charm-python-packages: [setuptools]
charm-binary-python-packages:
- cryptography
- jsonschema
- PyYAML
- attrs
- importlib-resources
- urllib3
- zipp
- cryptography
- jsonschema
- PyYAML
- attrs
- importlib-resources
- urllib3
- zipp
- pydantic-core
bases:
# This run-on is not as strict as the machine charm
# as the jimm-server runs in a container.
# So the only restriction for build-on vs run-on is
# So the only restriction for build-on vs run-on is
# the charm code.
- build-on:
- name: "ubuntu"
Expand Down
8 changes: 1 addition & 7 deletions charms/jimm-k8s/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,6 @@ options:
dns-name:
type: string
description: DNS hostname that JIMM is being served from.
vault-access-address:
type: string
description: |
The source address for the connection to Vault.
This should be a single IP with no CIDR.
E.g. 10.1.2.123
jwt-expiry:
type: string
description: |
Expand Down Expand Up @@ -92,7 +86,7 @@ options:
default: 86400
description: |
The max age for the session cookies in seconds, on subsequent logins, the session instance
extended by this amount.
extended by this amount.
final-redirect-url:
type: string
default: ""
Expand Down
Loading
Loading