Improve k8s charm test coverage #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added tests for create-auth-model action. - Added tests for Postgres relation. - Updated database lib to the latest maintained.
babakks
approved these changes
Apr 30, 2024
Comment on lines
413
to
431
| def mocked_requests_post(*args, **kwargs): | ||
| class MockResponse: | ||
| def __init__(self, json_data, status_code): | ||
| self.json_data = json_data | ||
| self.status_code = status_code | ||
| self.ok = True | ||
|
|
||
| def json(self): | ||
| return self.json_data | ||
|
|
||
| return MockResponse({"authorization_model_id": 123}, 200) | ||
|
|
||
| @mock.patch("src.charm.requests.post") | ||
| def test_create_auth_model_action(self, mock_post): | ||
| mock_post.side_effect = self.mocked_requests_post | ||
| self.harness.enable_hooks() | ||
| self.add_openfga_relation() | ||
| self.harness.run_action("create-authorization-model", {"model": "null"}) | ||
| self.assertEqual(self.harness.charm._state.openfga_auth_model_id, 123) |
There was a problem hiding this comment.
If mocked_requests_post is only used in this test (test_create_auth_model_action), I think it's better to move it's definition to the body of the test (instead of defining it at the class scope).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the JIMM k8s charm unit test coverage.
Adds tests for:
create-authorization-modelaction.Updated the postgres relation library to the latest one as the previously used one was deprecated. Also removed some unused code.
Partially addresses CSS-8235
Engineering checklist
Check only items that apply