Apply proxy login fix with Terraform #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
force-pushed
the
terraform-proxy-fixes
branch
from
05ad328 to
4bd56af
Compare
alesstimec
approved these changes
May 6, 2024
|
@alesstimec Will do, initially I thought we needed to be based on a version of Juju that included this PR but I don't think that's the case. |
Also updated gitignore
kian99
force-pushed
the
terraform-proxy-fixes
branch
from
24a4b46 to
2ef371c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue using Terraform and JIMM. The model proxy was not doing the same thing as the root controller. We need to properly fix this issue by refactoring the model proxy to use the same functions as the controller root, but this can be left for a separate PR.
This PR requires #1206 to land first to fix compile time issues as a result of this PR in Juju.Engineering checklist
Check only items that apply