CSS-8386 Use oauth state #1208
Merged
CSS-8386 Use oauth state #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ale8k
reviewed
May 8, 2024
ale8k
reviewed
May 8, 2024
ale8k
reviewed
May 8, 2024
kian99
force-pushed
the
CSS-8386-use-oauth-state
branch
from
63ec24c to
1b9841f
Compare
kian99
force-pushed
the
CSS-8386-use-oauth-state
branch
from
1b9841f to
923011b
Compare
babakks
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hydra enforces the use of state when performing the browser flow. This PR adds secure generation of the state parameter with
crypto/randand persists the state as a cookie on the user's browser. We set thepathparameter on the cookie to ensure it is only sent to the auth/callback endpoint. This required a bit of refactoring of the tests and I also removed the use of magic strings in favour of constants.Fixes CSS-8386
Engineering checklist
Check only items that apply