CSS-4546 - Backport ci/cd and supporting files #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ale8k
reviewed
Jun 22, 2023
| # # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version | ||
| # version: latest | ||
| # skip-pkg-cache: true | ||
| # skip-build-cache: true | ||
|
|
||
| build_test: |
There was a problem hiding this comment.
My inner OCD hates that this is _ and others are - :D
babakks
approved these changes
Jun 22, 2023
|
|
||
| lint: | ||
| # Delete this if statement once charms are updated and include tox. | ||
| if: ${{ 1 }} == ${{ 2 }} |
There was a problem hiding this comment.
I guess, you can also use:
if: !always()If you decided so, please update the other one below.
There was a problem hiding this comment.
It should dissapear soon anyway so I'll just leave it. Good to know about this though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an alternative to #961, here only the Github workflows have been backported from
feature-rebacalong with any changes needed to get the CI/CD working (which unfortunately were fairly numerous).For a rundown of what's changed and why,
Engineering checklist
Check only items that apply