workflow improvements #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Github action to release a charm has a nice feature to create a tag of the form
revXwhenever it pushes your charm but when you're building multiple charms, this tag can break your CI. This PR makes use of thetag-prefixparameter to address this.Also, to make life easier when making workflow related changes I've limited the CI job to only run when a file has changed outside the .github folder. But we do require in the repo settings that a status check is received so according to these docs I've added a similar check that will simply skip and allow the PR to receive a status check. This can be extended if there are certain folders we want to ignore on CI.