Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s-dqlite v1.3.0 (dqlite LTS) #843

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

louiseschmidtgen
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen commented Nov 26, 2024

K8s-dqlite v1.3.0 (Dqlite LTS)

This PR updates the k8s-dqlite version from v1.2.0 to v1.3.0.
Release notes: https://github.com/canonical/k8s-dqlite/releases/tag/v1.3.0

@louiseschmidtgen louiseschmidtgen requested a review from a team as a code owner November 26, 2024 10:18
@bschimke95
Copy link
Contributor

Looks like this does not build because of

# github.com/canonical/go-dqlite/v2/internal/bindings
/root/go/pkg/mod/github.com/canonical/go-dqlite/v2@v2.0.0/internal/bindings/server.go:265:11: could not determine kind of name for C.dqlite_node_describe_last_entry
# github.com/canonical/go-dqlite/v2/internal/bindings
/root/go/pkg/mod/github.com/canonical/go-dqlite/v2@v2.0.0/internal/bindings/server.go:265:11: could not determine kind of name for C.dqlite_node_describe_last_entry
make: *** [Makefile:31: bin/static/dqlite] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:27: bin/static/k8s-dqlite] Error 1
Failed to run 'override-build': Exit code was 2.

maybe the go-dqlite version is not right?

@louiseschmidtgen
Copy link
Contributor Author

Looks like this does not build because of

# github.com/canonical/go-dqlite/v2/internal/bindings
/root/go/pkg/mod/github.com/canonical/go-dqlite/v2@v2.0.0/internal/bindings/server.go:265:11: could not determine kind of name for C.dqlite_node_describe_last_entry
# github.com/canonical/go-dqlite/v2/internal/bindings
/root/go/pkg/mod/github.com/canonical/go-dqlite/v2@v2.0.0/internal/bindings/server.go:265:11: could not determine kind of name for C.dqlite_node_describe_last_entry
make: *** [Makefile:31: bin/static/dqlite] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:27: bin/static/k8s-dqlite] Error 1
Failed to run 'override-build': Exit code was 2.

maybe the go-dqlite version is not right?

Looks like we have an issue with the linked library during the build, I would suggest waiting on the microcluster backport to bump its dqlite version as well- instead of changing the build process.

@louiseschmidtgen louiseschmidtgen marked this pull request as draft November 26, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants