-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-3929] - feat: secrets integration #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoppenheimer
requested review from
zmraul,
deusebio and
Batalex
and removed request for
zmraul and
deusebio
May 1, 2024 15:26
deusebio
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following discussions and approval on canonical/kafka-operator#189
Batalex
requested changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like you said, a lot of test tweaking!
Batalex
approved these changes
May 3, 2024
zmraul
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K8s Specific Changes
fix: spurious error on upgrades when container wasn't ready
can_connect
at the start of the upgrade-specificpebble-ready
chore: drop exec failure logs down to DEBUG
ca already exists
keytool logging when re-writing the CA to the truststoreTest Changes
test: remove mTLS tests
test: add scaling and client-broken checks to tls tests
test: pytest.mark.unstable network_cut_without_ip_change and tls_pod_reschedule
test: re-enable some commented unit tests
test: sync unit tests with VM
pytestmark = pytest.mark.skipif(SUBSTRATE="k8s")
to skip an entire module's teststest: enable upgrade int tests after stable release
stable
release, we do now, so now we have teststest: add consume action to app-charm for use in upgrade int tests