Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-design default list of images handling in Katib #130

Closed
i-chvets opened this issue Aug 31, 2023 · 1 comment
Closed

Re-design default list of images handling in Katib #130

i-chvets opened this issue Aug 31, 2023 · 1 comment

Comments

@i-chvets
Copy link
Contributor

Description

Currently, katib-controller has default images hardcoded in the source code of the charm. PR: #98

In order to simplify maintenance of list of default images it is better to have default images in a separate file that can be loaded by charm. In similar fashion as it was done in Seldon canonical/seldon-core-operator#192

Solution

Added separate JSON file with list of default images and populate datastructures in the charm using this file.
@i-chvets i-chvets changed the title Re-design custom images handling in Katib Re-design default list of images handling in Katib Aug 31, 2023
This was referenced Aug 31, 2023
Closed
Closed
@i-chvets
Copy link
Contributor Author

i-chvets commented Sep 6, 2023

This issue was fixed by this PR: #133
Closing.

@i-chvets i-chvets closed this as completed Sep 6, 2023
@i-chvets i-chvets mentioned this issue Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@i-chvets