Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kf 3994 configurable images #98

Merged
merged 11 commits into from
Jul 26, 2023
Merged

Kf 3994 configurable images #98

merged 11 commits into from
Jul 26, 2023

Conversation

misohu
Copy link
Member

@misohu misohu commented Jul 20, 2023 •
edited
Loading

  • Allow to configure custom images for non metadata images
  • Use JSON/YAML to specify custom images

kimwnasptd
kimwnasptd reviewed Jul 20, 2023
View reviewed changes
README.md Show resolved Hide resolved
@misohu misohu marked this pull request as ready for review July 21, 2023 11:10
@misohu misohu requested a review from a team as a code owner July 21, 2023 11:10
NohaIhab
NohaIhab reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also cover with unit and integration tests?

charms/katib-controller/src/defaultTrialTemplate.yaml.j2 Outdated Show resolved Hide resolved
charms/katib-controller/src/charm.py Outdated Show resolved Hide resolved
@misohu misohu force-pushed the KF-3994-configurable-images branch from cba72c8 to f063f73 Compare July 25, 2023 08:19
NohaIhab
NohaIhab reviewed Jul 26, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@misohu misohu merged commit 9bfa7a2 into main Jul 26, 2023
@misohu misohu deleted the KF-3994-configurable-images branch July 26, 2023 11:04
@i-chvets i-chvets mentioned this pull request Aug 23, 2023
Closed
@i-chvets i-chvets mentioned this pull request Aug 31, 2023
Closed
NohaIhab pushed a commit that referenced this pull request Sep 26, 2023
@misohu @NohaIhab
Kf 3994 configurable images (#98)
0b546f1 
* Add configurable images from config
* Add integration tests for katib-controller
* Edit the CI to execute integration tests for katib-controller
* Pin Pyyaml to 6.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ca-scribner ca-scribner ca-scribner left review comments

@kimwnasptd kimwnasptd kimwnasptd left review comments

@NohaIhab NohaIhab NohaIhab approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@misohu @kimwnasptd @ca-scribner @NohaIhab