Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump libraries #257

Merged
merged 3 commits into from
Jan 16, 2025
Merged

chore: bump libraries #257

merged 3 commits into from
Jan 16, 2025

Conversation

orfeas-k
Copy link
Contributor

  • Bump libraries using charmcraft fetch-lib.
  • Check for major versions using noctua charm libraries check --major. If there is one, then commit a do-not-merge-message.txt file.

Ref canonical/bundle-kubeflow#1184

@orfeas-k orfeas-k force-pushed the kf-6654-bump-libraries branch from 9c6e6c4 to 1591cd0 Compare January 14, 2025 08:39
NohaIhab
NohaIhab requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's missing to bump the cosl version in requirements.txt and requirements-unit.txt

@orfeas-k orfeas-k merged commit d1f6358 into main Jan 16, 2025
25 checks passed
@orfeas-k orfeas-k deleted the kf-6654-bump-libraries branch January 16, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NohaIhab NohaIhab NohaIhab approved these changes

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orfeas-k @NohaIhab