feat: kfp-viz sidecar rewrite with base charm #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: Out of sync
labels
|
Confirming that all comments, reviews, and conversation resolutions from #305 gold true for this PR. |
|
@NohaIhab We need to update bunde definition to include trust: https://github.com/canonical/bundle-kubeflow/blob/main/releases/latest/edge/bundle.yaml#L120 This PR LGTM. Approving. |
i-chvets
pushed a commit
to canonical/bundle-kubeflow
that referenced
this pull request
Aug 24, 2023
Summary of changes: - Added trust to kfp-viz to support newly re-written charm canonical/kfp-operators#309
NohaIhab
added a commit
to canonical/bundle-kubeflow
that referenced
this pull request
Aug 25, 2023
* fix: added trust to kfp-viz to support new charm Summary of changes: - Added trust to kfp-viz to support newly re-written charm canonical/kfp-operators#309 --------- Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #305 due to unverified commits
Rewrite the
kfp-vizcharm, migrating it from podspec to sidecar using the reusable base charm in charmed-kubeflow-chisme. More details on the base charm in this README.mdSummary of changes
NOTE: Due to deployment parameter in PodSpec version, kfp-persistence cannot be upgraded using Juju refresh:
juju.errors.JujuAPIError: Juju on containers does not support updating deployment info for services.
Upgrade will be done by re-deploying the charm.