Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-server): Enable charm configuration of launcher and driver images #455

Merged
merged 6 commits into from
May 22, 2024

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented May 9, 2024

Enable charm configuration of launcher and driver images used during pipeline steps. Those can be configured thourgh values launcher-image and driver-image. When unset, KFP uses the default values defined. This is based on upstream implementation introduced in kubeflow/pipelines#10269.

Closes #452

Testing

This was tested with upstream image gcr.io/ml-pipeline/api-server:2.0.5. The rest of kfp used the ROCKs.

It can be tested that pipeline steps are using the proper images by configuring the charm and then running a pipeline.

juju config kfp-api launcher-image="fake-image"
juju config kfp-api driver-image="fake-image"

You should see pods created by the pipeline run that spin up containers using the images provided in the config options.

Note that:

  • Each configuration should be tested separately. A pod using the launcher-image is only spun up after (at least some) driver-image pods are completed. Thus, launcher-image configuration can only be tested when driver-image config is healthy.
  • When rerunning the same exact pipeline, KFP will use the launcher spun up previously, if one was successfully created, instead of spinning a new one (thus the previously used launcher-image).

Enable charm configuration of launcher and driver images used during
pipeline steps. Those can be configured thourgh values `launcher-image`
and `driver-image`. When unset, KFP uses the default images defined in
upstream code.
Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm but we need to update the tools/get-images.sh file as commented

@NohaIhab
Copy link
Contributor

NohaIhab commented May 10, 2024

I synced with @orfeas-k to test this, and it was working correctly for me!
We agreed to add to the PR the instructions that we tested with.

update: instructions now in the PR description

@kimwnasptd
Copy link
Contributor

Deployed as well the Charm and managed to change the images successfully.

@ca-scribner ca-scribner dismissed their stale review May 22, 2024 12:35

already addressed and approved by someone else

@orfeas-k orfeas-k merged commit edae7c5 into main May 22, 2024
46 checks passed
orfeas-k added a commit that referenced this pull request May 22, 2024
…455)

Enable charm configuration of launcher and driver images used during pipeline steps. Those can be configured through config options `launcher-image` and `driver-image`. When unset, KFP uses the default values defined. This is based on upstream implementation introduced in kubeflow/pipelines#10269.

Closes #452
orfeas-k added a commit that referenced this pull request May 22, 2024
backport(feat): Enable configuration in kfp-api of launcher and driver images from #455

Closes #453
@orfeas-k orfeas-k deleted the kf-5637-kfp-api-images-configuration branch November 28, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose configuration of kfp-api's launcher and driver images in charm config in main
4 participants