-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-server): Enable charm configuration of launcher and driver images #455
Conversation
Enable charm configuration of launcher and driver images used during pipeline steps. Those can be configured thourgh values `launcher-image` and `driver-image`. When unset, KFP uses the default images defined in upstream code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm but we need to update the tools/get-images.sh
file as commented
I synced with @orfeas-k to test this, and it was working correctly for me! update: instructions now in the PR description |
Deployed as well the Charm and managed to change the images successfully. |
already addressed and approved by someone else
…455) Enable charm configuration of launcher and driver images used during pipeline steps. Those can be configured through config options `launcher-image` and `driver-image`. When unset, KFP uses the default values defined. This is based on upstream implementation introduced in kubeflow/pipelines#10269. Closes #452
Enable charm configuration of launcher and driver images used during pipeline steps. Those can be configured thourgh values
launcher-image
anddriver-image
. When unset, KFP uses the default values defined. This is based on upstream implementation introduced in kubeflow/pipelines#10269.Closes #452
Testing
This was tested with upstream image
gcr.io/ml-pipeline/api-server:2.0.5
. The rest of kfp used the ROCKs.It can be tested that pipeline steps are using the proper images by configuring the charm and then running a pipeline.
You should see pods created by the pipeline run that spin up containers using the images provided in the config options.
Note that:
launcher-image
is only spun up after (at least some)driver-image
pods are completed. Thus,launcher-image
configuration can only be tested whendriver-image
config is healthy.launcher-image
).