fix: Parse custom images with ":" in their name #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 3 of the images (i.e. explainers), the charm attempts to separate the image name from the tag, splitting the string in two using `:` as a separator. However, this breaks the installation if the image name contains that special character, which could be the case if a local container registry address is provided for instance (e.g. 172.17.0.2:5000/kserve/alibi-explainer:latest). Use `rsplit` to ensure that the rightmost part of the string (following the last `:`) is parsed as the tag. Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@canonical.com>
orfeas-k
approved these changes
Aug 31, 2023
misohu
pushed a commit
that referenced
this pull request
Sep 26, 2023
For 3 of the images (i.e. explainers), the charm attempts to separate the image name from the tag, splitting the string in two using `:` as a separator. However, this breaks the installation if the image name contains that special character, which could be the case if a local container registry address is provided for instance (e.g. `172.17.0.2:5000/kserve/alibi-explainer:latest`). Use `rsplit` to ensure that the rightmost part of the string (following the last `:`) is parsed as the tag. Closes #159 Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 3 of the images (i.e. explainers), the charm attempts to separate the image name from the tag, splitting the string in two using
:as a separator. However, this breaks the installation if the image name contains that special character, which could be the case if a local container registry address is provided for instance (e.g.172.17.0.2:5000/kserve/alibi-explainer:latest).Use
rsplitto ensure that the rightmost part of the string (following the last:) is parsed as the tag.Closes #159