-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add controller rock (v0.11.2) #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NohaIhab ! For some reason I am not able to build the rock to test it. Do you think there is something wrong with my setup? I get this:
ubuntu@charm-dev-jammy:~/kserve-rocks/controller$ rockcraft --version
rockcraft 1.2.2
ubuntu@charm-dev-jammy:~/kserve-rocks/controller$ rockcraft pack
ubuntu@charm-dev-jammy:~/kserve-rocks/controller$ ls
rockcraft.yaml tests tox.ini
ubuntu@charm-dev-jammy:~/kserve-rocks/controller$
@DnPlas that's odd, is there no output from the pack command? maybe try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DnPlas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NohaIhab !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @NohaIhab :)
closes #32