Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pebble service name for admission-webhook #137

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

mvlassis
Copy link
Contributor

@mvlassis mvlassis commented Sep 16, 2024

Closes #136.

This PR simply changes the name of the Pebble service in the admission-webhook rock to match the container name defined in the charm operator's code, found here. This way, only one Pebble service is created.

To test:

  • Clone the repository and checkout to this branch
  • cd to the admission-webhook directory and run tox -e pack
  • tox -e export-to-docker
  • Clone the admission-webhook-operator repository, found here.
  • Change the value of oci-image in metadata.yaml to the image name that was exported (prepending docker.io/library/ to the image name).
  • Run the integration tests with tox -e integration -- --model kubeflow
  • Tests should pass :)

@mvlassis mvlassis requested a review from a team as a code owner September 16, 2024 14:31
Copy link
Collaborator

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice catch! Thanks @mvlassis !

@mvlassis mvlassis merged commit b041e5f into main Sep 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admission-webhook: Multiple Pebble services when integrated into Charmed Kubeflow
2 participants