Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add reusable CI for build, publish, test and scans #73

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

DnPlas
Copy link
Collaborator

@DnPlas DnPlas commented Jan 31, 2024

Refactor the CI and re-use the workflows in charmed-kubeflow-workflows repository. This commit adds workflows for:

  • build and publish workflow dispatch
  • build, scan, test, and publish on push and PR

Fixes #70

Dear reviewer, please NOTE this PR's CI will fail until all rockcraft projects in this repo have the following:

  • An up to date rockcraft file with the latest supported format (i.e. base and version must be valid)
  • Each rockcraft project directory must have a tox.ini file with envlist = pack, export-to-docker, sanity, integration
  • Each rockcraft project directory must have a tests/ directory with sanity tests inside. Example here

Refactor the CI and re-use the workflows in charmed-kubeflow-workflows repository.
This commit adds workflows for:
* build and publish workflow dispatch
* build, scan, test, and publish on push and PR

Fixes #70
@DnPlas DnPlas requested a review from a team as a code owner January 31, 2024 15:55
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the repo's CI:)

@DnPlas DnPlas merged commit 98ac197 into main Feb 4, 2024
2 checks passed
@DnPlas DnPlas deleted the KF-5224-update-repo-ci branch June 21, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubeflow-rocks: Update push and pull_request CI
2 participants