-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pytorch cpu jupyter server rock #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I 'm adding some comments here since I could not comment on unchanged code:
- Is there a chance we need to update the following line? Although I see they still set the same NB_USER .
chown -R 584792:users home/jovyan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Good job @misohu. This was a convoluted ROCK actually with a lot of digging needed but you pulled through as always 👏
This PR fixes (refer to the issue for the whole discussion):
canonical/data-science-stack#47
This PR also fixes some problems from here #78. Namely it updates python, miniforge and it uses mamba. We still need to figure out the s6 and builds for different architectures.
I updated the rock based of upstream changes in branch
v1.8-branch
hereKey changes:
Changes in tests:
CI is failing because trivy scan times out as the rock is too big. I fixed this in this PR which should be merged first and then we can rerun ci (I did that in previous commit with pinned branch in CI).