Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add terraform modules for tensorboard controller and web-app charms #142

Merged
merged 10 commits into from
Sep 24, 2024
Merged

feat: add terraform modules for tensorboard controller and web-app charms #142

merged 10 commits into from
Sep 24, 2024

Conversation

NohaIhab
Copy link
Contributor

@NohaIhab NohaIhab commented Sep 20, 2024 •
edited
Loading

Closes #140
Closes #141

Create a terraform/ directory for each of the charms that hosts their individual Terraform modules. It follows the structure proposed in this spec and it is based on what was done in canonical/argo-operators#198.

To test the modules:

  • Clone the repository and switch this PR's branch.
  • For each charm:
    • cd into its directory
    • First run tox -e tflint to ensure that linting is correct
    • Create a juju controller and a model name kubeflow
    • Run terraform apply -var "channel=latest/edge" -var "model_name=kubeflow" --auto-approve

Expected juju status:

App                     Version  Status   Scale  Charm                   Channel      Rev  Address        Exposed  Message
tensorboard-controller           waiting      1  tensorboard-controller  latest/edge  358  10.152.183.36  no       installing agent
tensorboards-web-app             waiting      1  tensorboards-web-app    latest/edge  346  10.152.183.53  no       installing agent

Unit                       Workload  Agent  Address       Ports  Message
tensorboard-controller/0*  waiting   idle   10.1.199.196         Waiting for gateway info relation
tensorboards-web-app/0*    blocked   idle   10.1.199.252         Please relate to istio-pilot:ingress

@NohaIhab NohaIhab requested a review from a team as a code owner September 20, 2024 08:20
mvlassis
mvlassis reviewed Sep 20, 2024
View reviewed changes
Copy link

@mvlassis mvlassis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small comments, nice work!

orfeas-k
orfeas-k reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

charms/tensorboards-web-app/terraform/README.md Outdated Show resolved Hide resolved
mvlassis
mvlassis approved these changes Sep 24, 2024
View reviewed changes
Copy link

@mvlassis mvlassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work Noha!

@NohaIhab NohaIhab merged commit cb3bc6c into main Sep 24, 2024
20 checks passed
@NohaIhab NohaIhab deleted the kf-6221-terraform-modules branch September 24, 2024 13:54
NohaIhab added a commit that referenced this pull request Sep 25, 2024
@NohaIhab
feat: add terraform modules for tensorboard controller and web-app ch…
19a0e09 
…arms (#142)

* feat: add terraform modules for tensorboard controller and web-app
* fix: skip terraform apply
@NohaIhab NohaIhab mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orfeas-k orfeas-k orfeas-k left review comments

@mvlassis mvlassis mvlassis approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a terraform module for web app charm Create a terraform module for controller charm
3 participants
@NohaIhab @orfeas-k @mvlassis