pkg/ruler/rulestore/configdb: Preallocate memory (grafana#7326)

Preallocate memory instead of enforcing an incremental growth. This will result in less work for the garbage collector.
canonical · Dec 1, 2022 · 8e816d9 · 8e816d9
1 parent 74e64f0
commit 8e816d9
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/pkg/ruler/rulestore/configdb/store.go b/pkg/ruler/rulestore/configdb/store.go
@@ -36,8 +36,7 @@ func NewConfigRuleStore(c client.Client) *ConfigRuleStore {
 func (c *ConfigRuleStore) ListAllUsers(ctx context.Context) ([]string, error) {
 	m, err := c.ListAllRuleGroups(ctx)
 
-	// TODO: this should be optimized, if possible.
-	result := []string(nil)
+	result := make([]string, 0, len(m))
 	for u := range m {
 		result = append(result, u)
 	}