Update long device name on TPM tests #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This even longer name tests for problems with device ID trmming on QEMU and tests using `/` in TPM names Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
hamistao
force-pushed
the
update_tpm_tests
branch
from
a86df91 to
b39b80e
Compare
simondeziel
reviewed
Jun 27, 2024
There was a problem hiding this comment.
The test with latest/edge on 24.04 is unhappy https://github.com/canonical/lxd-ci/actions/runs/9690735014/job/26741083206#step:7:566
|
TPM tests should pass after #13671 is merged |
Sorry, I missed that failure was expected until that PR was merged. That also means earlier releases still need to be excluded, thanks. |
simondeziel
approved these changes
Jun 27, 2024
tomponline
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This even longer name tests for problems with device ID trmming on QEMU and tests using
/in TPM names. See #13671.