Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at fixing canonical/lxd#14341
This changes how
lvm.conf
is patched to be done at build time rather than atdaemon.start
time. This implies that now, executables are using/snap/lxd/current
instead of/snap/lxd/${rev}
./etc/lvm/profile
files are now included in the snap. It's unclear if they are used or not but they are so small (11KiB) that it doesn't hurt to ship them.Lastly, the daemon visible
/etc/lvm
dir now contains 2 symlinks pointing to the read-only snap mount while still allowing the creation of the/etc/lvm/archive
and/etc/lvm/backup
directories backed by thetmpfs
/etc
: