-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic during test run #12540
Comments
I'll just paste here some more action logs for later reference if needed: |
Still happening occaisionally:
|
I suspect this is a result of |
Because we are storing the `task.Group` by value in `Daemon`, replacing it after the timeout re-initializes the Mutex, leaving it unlocked. If some task exceeds the timeout at just the right time, it will lock the old mutex and then unlock the new one, generating a panic. Fixes canonical#12540 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Confirmed it with this patch: https://gist.github.com/MggMuggins/11bd05305a780f552bfa930b8d7ef8ac. |
Thanks! |
Because we are storing the `task.Group` by value in `Daemon`, replacing it after the timeout re-initializes the Mutex, leaving it unlocked. If some task exceeds the timeout at just the right time, it will lock the old mutex and then unlock the new one, generating a panic. Fixes canonical#12540 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Because we are storing the `task.Group` by value in `Daemon`, replacing it after the timeout re-initializes the Mutex, leaving it unlocked. If some task exceeds the timeout at just the right time, it will lock the old mutex and then unlock the new one, generating a panic. Fixes canonical#12540 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Because we are storing the `task.Group` by value in `Daemon`, replacing it after the timeout re-initializes the Mutex, leaving it unlocked. If some task exceeds the timeout at just the right time, it will lock the old mutex and then unlock the new one, generating a panic. Fixes canonical#12540 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Because we are storing the `task.Group` by value in `Daemon`, replacing it after the timeout re-initializes the Mutex, leaving it unlocked. If some task exceeds the timeout at just the right time, it will lock the old mutex and then unlock the new one, generating a panic. Fixes canonical#12540 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Because we are storing the `task.Group` by value in `Daemon`, replacing it after the timeout re-initializes the Mutex, leaving it unlocked. If some task exceeds the timeout at just the right time, it will lock the old mutex and then unlock the new one, generating a panic. Fixes canonical#12540 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Noticed from https://github.com/canonical/lxd/actions/runs/6944517919/job/18891832516?pr=12515
The text was updated successfully, but these errors were encountered: