Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Licence check fails on Go 1.22.0 #13048

Closed
markylaing opened this issue Mar 5, 2024 · 1 comment · Fixed by #13639
Closed

Licence check fails on Go 1.22.0 #13048

markylaing opened this issue Mar 5, 2024 · 1 comment · Fixed by #13639
Assignees
@simondeziel
Labels
Bug Confirmed to be a bug
Milestone
lxd-6.2

Comments

@markylaing
Copy link
Contributor

See https://github.com/canonical/lxd/actions/runs/8156637138/job/22299617287#step:13:305 and #13042 (comment)
@markylaing markylaing self-assigned this Mar 5, 2024
@tomponline tomponline added the Bug Confirmed to be a bug label Mar 5, 2024
@tomponline tomponline added this to the lxd-6.1 milestone Mar 5, 2024
@tomponline
Copy link
Member

From my observations it works fine on go 1.22 when using @latest but this fails on our GH worflows because make static-analysis is pinned at go 1.21 due to swagger incompatibility with go 1.22. go-swagger/go-swagger#3070

@tomponline tomponline changed the title Licence check fails on Go 1.22.0. Licence check fails on Go 1.22.0 May 3, 2024
@tomponline tomponline modified the milestones: lxd-6.1, lxd-6.2 May 12, 2024
@simondeziel simondeziel mentioned this issue Jun 19, 2024
Merged
tomponline pushed a commit to tomponline/lxd that referenced this issue Jun 21, 2024
@simondeziel @tomponline
Revert "test/lint: Disable licence check."
390ffdc 
This reverts commit f8180de.

It's possible now that we require Go 1.22+. Fixes canonical#13048

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
tomponline pushed a commit to tomponline/lxd that referenced this issue Jun 21, 2024
@simondeziel @tomponline
Revert "test/lint: Disable licence check."
711c027 
This reverts commit f8180de.

It's possible now that we require Go 1.22+. Fixes canonical#13048

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
tomponline pushed a commit to tomponline/lxd that referenced this issue Jun 21, 2024
@simondeziel @tomponline
Revert "test/lint: Disable licence check."
0414415 
This reverts commit f8180de.

It's possible now that we require Go 1.22+. Fixes canonical#13048

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
tomponline pushed a commit to tomponline/lxd that referenced this issue Jun 21, 2024
@simondeziel @tomponline
Revert "test/lint: Disable licence check."
bef9799 
This reverts commit f8180de.

It's possible now that we require Go 1.22+. Fixes canonical#13048

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
tomponline pushed a commit to tomponline/lxd that referenced this issue Jun 21, 2024
@simondeziel @tomponline
Revert "test/lint: Disable licence check."
8397c57 
This reverts commit f8180de.

It's possible now that we require Go 1.22+. Fixes canonical#13048

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
tomponline pushed a commit to tomponline/lxd that referenced this issue Jun 21, 2024
@simondeziel @tomponline
Revert "test/lint: Disable licence check."
abea0ad 
This reverts commit f8180de.

It's possible now that we require Go 1.22+. Fixes canonical#13048

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simondeziel simondeziel

Labels
Bug Confirmed to be a bug
Projects
None yet
Milestone
lxd-6.2
Development

Successfully merging a pull request may close this issue.

Revert "test/lint: Disable licence check." simondeziel/lxd
3 participants
@tomponline @simondeziel @markylaing