Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-Agent doesn't survive http redirects #2805

Closed
stgraber opened this issue Jan 20, 2017 · 0 comments
Closed

User-Agent doesn't survive http redirects #2805

stgraber opened this issue Jan 20, 2017 · 0 comments
Labels
Bug Confirmed to be a bug
Milestone
lxd-2.9

Comments

@stgraber
Copy link
Contributor

Because of golang/go#4800 our custom User-Agent is dropped when going through a redirect. This mostly affects communications with our image servers and so silently drops otherwise very useful information.

We should find a way to propagate our headers to any follow-up http request that's caused by a redirect.
@stgraber stgraber added the Bug Confirmed to be a bug label Jan 20, 2017
@stgraber stgraber modified the milestones: soon, lxd-2.9 Jan 23, 2017
@stgraber stgraber mentioned this issue Feb 15, 2017
Merged
stgraber added a commit that referenced this issue Feb 25, 2017
@stgraber
Forward user-agent and other headers on redirect
cb17028 
We don't use sensitive headers so don't need to be concerned about
crossing domain boundaries. So simply always copy all headers to
subsequent requests in the redirect chain.

Closes #2805

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Confirmed to be a bug
Projects
None yet
Milestone
lxd-2.9
Development

No branches or pull requests
1 participant
@stgraber