Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Enable PKI and concurrent tests #12096

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

tomponline
Copy link
Member

No description provided.

@tomponline tomponline self-assigned this Aug 1, 2023
@tomponline tomponline marked this pull request as ready for review August 1, 2023 09:52
Copy link
Contributor

@monstermunchkin monstermunchkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message of the first commit is confusing:

And disable swtpm apprmor rules for tpm tests

The commit only adds easy-rsa and enables concurrent tests. Am I missing something?

@tomponline
Copy link
Member Author

The commit message of the first commit is confusing:

And disable swtpm apprmor rules for tpm tests

The commit only adds easy-rsa and enables concurrent tests. Am I missing something?

Oh good spot I originally tried enabling swtpm but the github runners dont have the kernel module, will update. ta

… tests

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline
Copy link
Member Author

@monstermunchkin fixed

@tomponline tomponline merged commit 04447df into canonical:main Aug 1, 2023
23 of 24 checks passed
@tomponline tomponline deleted the tp-tests-easyrsa branch August 1, 2023 10:44
@simondeziel
Copy link
Member

Oh good spot I originally tried enabling swtpm but the github runners dont have the kernel module, will update. ta

Github runners probably have the Azure kernel flavor which might have a different set of config. Do you know which module/CONFIG_ was missing?

@tomponline
Copy link
Member Author

vtpm I think

@simondeziel
Copy link
Member

Thanks, I didn't find any exact match but the following is available:

$ dpkg -L "linux-modules-extra-$(uname -r)" | grep -F tpm
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/st33zp24
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/st33zp24/tpm_st33zp24.ko
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/st33zp24/tpm_st33zp24_i2c.ko
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/st33zp24/tpm_st33zp24_spi.ko
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/tpm_atmel.ko
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/tpm_i2c_atmel.ko
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/tpm_i2c_infineon.ko
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/tpm_i2c_nuvoton.ko
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/tpm_infineon.ko
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/tpm_nsc.ko
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/tpm_tis_i2c_cr50.ko
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/tpm_tis_spi.ko
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/tpm_vtpm_proxy.ko
/lib/modules/5.19.0-50-generic/kernel/drivers/char/tpm/xen-tpmfront.ko

And if one of the above is needed, presumably just an apt-get install "linux-modules-extra-$(uname -r)" away.

@tomponline
Copy link
Member Author

welcome to try it

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants