lxddoc: Within a config group, alphabetically sort the config options #12114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monstermunchkin
suggested changes
Aug 3, 2023
lxd/config/generate/lxddoc.go
Outdated
Comment on lines
209
to
210
| c := configEntry.(map[string]any) | ||
| for k := range c { |
There was a problem hiding this comment.
Suggested change
| c := configEntry.(map[string]any) | |
| for k := range c { | |
| for k := range configEntry.(map[string]any) { |
There was a problem hiding this comment.
Actually, c is further used within the loop
There was a problem hiding this comment.
Oh right, I overlooked that.
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
gabrielmougard
force-pushed
the
fix/lxddoc-sorting
branch
from
ae1ac4c
to
2706a0f
Compare
|
@monstermunchkin added a unit test for the sorting function |
monstermunchkin
approved these changes
Aug 3, 2023
|
thanks |
ru-fu
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Works as expected, thanks! :)
This is ready for merging @tomponline
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alphabetically sort the config options within a config group