Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxd/resources: Use lshw if DMI is not available #12202

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

monstermunchkin
Copy link
Contributor

If DMI is not available, lshw is used to retrieve system information.

Fixes #12112

Signed-off-by: Thomas Hipp thomas.hipp@canonical.com

Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and elegant, LGTM

lxd/resources/system.go Outdated Show resolved Hide resolved
lxd/resources/system.go Outdated Show resolved Hide resolved
If DMI is not available, `lshw` is used to retrieve system information.

Fixes canonical#12112

Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomponline tomponline merged commit addea19 into canonical:main Sep 4, 2023
@monstermunchkin monstermunchkin deleted the issues/12112-lshw branch September 5, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If /sys/class/dmi/id is missing, fallback to parsing lshw's output
3 participants