Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better document loki.api.url #12272

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Better document loki.api.url #12272

merged 4 commits into from
Sep 19, 2023

Conversation

simondeziel
Copy link
Member

Partly address #12271

@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Sep 18, 2023
@simondeziel
lxd/cluster/config: add a long desc to loki.api.url
145a27a 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
lxd/metadata: add a long desc to loki.api.url
cc2068a 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
doc/config_options: add a long desc to loki.api.url
002a5fc 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
doc/api-extensions: explain the expected format of loki.api.url
1d0f272 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel marked this pull request as ready for review September 18, 2023 19:04
@tomponline tomponline merged commit fd28846 into canonical:main Sep 19, 2023
25 checks passed
@simondeziel simondeziel deleted the loki-api-url branch September 19, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simondeziel @tomponline