Enforce security.shifted and security.unmapped to be mutually exclusive.
#12316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monstermunchkin
previously approved these changes
Sep 26, 2023
MusicDin
previously approved these changes
Sep 26, 2023
It turns out that these are only added to the validation rules if the volume is a custom filesystem volume: Lines 444 to 447 in 188c290 So the extra validation is unnecessary. I'll remove the extra checks and just ensure they are mutually exclusive. |
'security.unmapped' and 'security.shifted' only make sense for custom volumes and they may not be set together. Signed-off-by: Mark Laing <mark.laing@canonical.com>
This will be checked via the call to ValidateVolume above, which calls the validator in the common driver. Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
markylaing
dismissed stale reviews from MusicDin and monstermunchkin
via
527479b
markylaing
force-pushed
the
storage-volume-config-mutually-exclusive
branch
from
b355745
to
527479b
Compare
tomponline
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check to the common driver volume validation that the
security.shiftedandsecurity.unmappedconfig options are only set on custom volumes and cannot be set at the same time.