Operation wait extension #12380
Merged
Operation wait extension #12380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
MusicDin
reviewed
Oct 13, 2023
tomponline
reviewed
Oct 13, 2023
markylaing
force-pushed
the
operation-wait-extension
branch
from
52e07ba to
9e2fbf9
Compare
tomponline
reviewed
Oct 13, 2023
Signed-off-by: Mark Laing <mark.laing@canonical.com>
…o events API. Signed-off-by: Mark Laing <mark.laing@canonical.com>
markylaing
force-pushed
the
operation-wait-extension
branch
from
9e2fbf9 to
5aeb90c
Compare
tomponline
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12349 introduced to the client the concept of waiting for an operation to complete via the operation wait endpoint rather than using the events websocket. This is used for
InstanceExecandInstanceConsole.Unfortunately this did not work for VMs as the lxd-agent did not contain the operation wait endpoint. This was fixed in #12372, but this fix will not work for older versions of the lxd-agent. This change introduces an API extension for the change so that we can check if the operation wait endpoint exists before choosing how to handle waiting for the operation.