Ensure the remote connection using simplestreams is valid before adding it #12442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
reviewed
Oct 23, 2023
tomponline
reviewed
Oct 23, 2023
…reams remote Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
gabrielmougard
force-pushed
the
fix/test-remote-add-connectivity
branch
from
d317683
to
17cbce8
Compare
tomponline
approved these changes
Oct 24, 2023
simondeziel
reviewed
Oct 24, 2023
| # a connectivity issue returns an error | ||
| ! lxc_remote remote add ubuntu1 https://cloud-images.ubuntu.com:1234/releases --protocol=simplestreams | ||
| # a malformed url path returns an error | ||
| ! lxc_remote remote add ubuntu2 https://cloud-images.ubuntu.com/buildd/releases/ --protocol=simplestreams --public |
There was a problem hiding this comment.
If the issue is the trailing "/", I would update the comment to say that trailing "/" are not permitted, rather than it being a malformed URL.
There was a problem hiding this comment.
Ive not had time to debug it much, but that line is one of the issues.
The other thing is that it broke adding valid simplestreams URLs without --public being specified as it then treated them as LXD image servers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12414