test/suites: Fixes wait_no_operations helper. #12464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markylaing
requested review from
monstermunchkin,
simondeziel,
gabrielmougard and
MusicDin
|
any ideas why it wasnt failing on github? |
MusicDin
approved these changes
Oct 25, 2023
gabrielmougard
approved these changes
Oct 25, 2023
No, I'm quite baffled. Returning nothing if the response is an empty object is very intentional Line 177 in e186300 and has had this logic since 2017. |
simondeziel
reviewed
Oct 25, 2023
Signed-off-by: Mark Laing <mark.laing@canonical.com>
markylaing
force-pushed
the
wait-no-operations-empty-response
branch
from
09760d5 to
84b7512
Compare
simondeziel
approved these changes
Oct 26, 2023
tomponline
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_operationstest is failing for me on main because the result oflxc query /1.0/operations?all-projects=trueis empty when there are no operations. If this is a problem with LXD and not just the test please let me know!