Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/deps: switch to ecdsa certificate #12472

Merged
merged 3 commits into from
Oct 31, 2023
Merged

test/deps: switch to ecdsa certificate #12472

merged 3 commits into from
Oct 31, 2023

Conversation

simondeziel
Copy link
Member

No description provided.

@simondeziel simondeziel marked this pull request as ready for review October 27, 2023 00:53
@tomponline
Copy link
Member

Shall we generate the cert on the fly rather than having static assets without clear reproducer steps?

@simondeziel
test/deps: switch to ecdsa certificate
837f8c5 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
github: shorten job names to improve the UI view
9fe9a3e 
Prior to that change, completed tests would be reported as:

System tests (1.18.x, cluster, ceph)
System tests (1.18.x, cluster, ran...
System tests (1.18.x, standalone...
System tests (1.18.x, standalone...
System tests (1.18.x, standalone...
System tests (1.18.x, standalone...
System tests (1.18.x, standalone...
System tests (1.18.x, standalone...
System tests (stable, cluster, dir)

Having the storage bakend label dropped from the links made it
harder to quickly identify which failed/succeeded.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/clustering: remove unneeded shellcheck ignore and update others
7fadf2d 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
Copy link
Member Author

Shall we generate the cert on the fly rather than having static assets without clear reproducer steps?

I tried the openssl command we use to generate a metrics client cert/key pair but that has the CA: TRUE bit added to it which isn't the case when LXD generates it's own server cert/key pair. So I couldn't find an easy way to do that in shell and resorted with a throwaway LXD server :)

@tomponline
Copy link
Member

Shall we generate the cert on the fly rather than having static assets without clear reproducer steps?

I tried the openssl command we use to generate a metrics client cert/key pair but that has the CA: TRUE bit added to it which isn't the case when LXD generates it's own server cert/key pair. So I couldn't find an easy way to do that in shell and resorted with a throwaway LXD server :)

Could you create a little go program in the test dir that does this (we've got several small helper programs already there).

@simondeziel
Copy link
Member Author

@tomponline would you consider merging this as is? I'd be happy to work on the little Go helper later on.

@tomponline tomponline merged commit e9b36f7 into canonical:main Oct 31, 2023
24 of 26 checks passed
@simondeziel simondeziel deleted the ecdsa-test-server-cert branch October 31, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simondeziel @tomponline