Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict user.* keys #12487

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

monstermunchkin
Copy link
Contributor

This restricts user.* keys to only include letters, digits, and punctuation characters.

Fixes #12308

This restricts user.* keys to only allow letters, digits, and
punctuation characters.

Fixes canonical#12308

Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test, for completeness, maybe we could add a working one to be sure the feature works before checking for restrictions applied to it.

Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomponline tomponline merged commit 1be6a0b into canonical:main Nov 6, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LXD should restrict which user.* key names it accepts
3 participants