btrfs: Handle pools whose source is a subvolume outside of the pool mount path #12498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
reviewed
Nov 4, 2023
tomponline
reviewed
Nov 4, 2023
monstermunchkin
force-pushed
the
issues/12496-btrfs
branch
from
f0f221f
to
bb9136b
Compare
This adds a new function which checks whether the given path has subvolumes. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
This replaces `getSubvolumes` with `hasSubvolumes` when creating a new storage pool as the caller isn't interested in what the subvolumes are. It also fixes a regression which caused storage pools with `source` set to an existing subvolume to fail when being created. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
monstermunchkin
force-pushed
the
issues/12496-btrfs
branch
from
bb9136b
to
bdf3b36
Compare
tomponline
approved these changes
Nov 16, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where btrfs pools whose source is a subvolume outside of the pool mount path would fail being created.
However, as this scenario is totally valid, it should be handled correctly.
Fixes #12496
Fixes regression from 7ebca54 in #12258