lxc/delete: Include instance name in error message #12499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
reviewed
Nov 3, 2023
tomponline
reviewed
Nov 3, 2023
monstermunchkin
force-pushed
the
misc/lxc-delete
branch
from
000b4c2 to
68ae8d7
Compare
simondeziel
previously approved these changes
Nov 3, 2023
tomponline
reviewed
Nov 4, 2023
monstermunchkin
force-pushed
the
misc/lxc-delete
branch
from
68ae8d7 to
70fde65
Compare
|
Please can you rebase. |
When deleting multiple instances at once, it's not clear which deletion failed as the instance name is not included in the error message. This adds the instance name to the error message. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
monstermunchkin
force-pushed
the
misc/lxc-delete
branch
from
70fde65 to
091045c
Compare
tomponline
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting multiple instances at once, it's not clear which deletion
failed as the instance name is not included in the error message.
This adds the instance name to the error message.