Trust ca certs #12513
Merged
Trust ca certs #12513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes canonical#218 Signed-off-by: Stéphane Graber <stgraber@stgraber.org> Signed-off-by: Mark Laing <mark.laing@canonical.com>
tomponline
previously approved these changes
Nov 7, 2023
markylaing
force-pushed
the
trust-ca-certs
branch
2 times, most recently
from
7ba9039
to
e4002f2
Compare
The test as it was written was quite incorrect. core.trust_ca_certificates causes valid certificates to be implictly trusted and not get a certificate store entry. But as the test was run immediately after a configuration where core.trust_ca_certificates was not set, there was a leftover entry in the trust store which the test was then checking. This corrects the test by clearing the trust store after the initial test and by further making sure that when using core.trust_ca_certificates, no trust store entries get created. Signed-off-by: Stéphane Graber <stgraber@stgraber.org> Signed-off-by: Mark Laing <mark.laing@canonical.com>
…ler. Previously we ran the access handler regardless of whether a request was authenticated. This would usually fail because there would be no username in the request context. However we need to be careful that a user is authenticated if predicating access on the presence of a CA certificate. Signed-off-by: Mark Laing <mark.laing@canonical.com>
markylaing
force-pushed
the
trust-ca-certs
branch
from
e4002f2
to
7cce0df
Compare
tomponline
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks fixes from lxc/incus#221 which prevented TLS authorization when using CA certificates.
I have added an extra commit to enforce that a user is authenticated before calling the access handler.