Import from incus #12532
Merged
Import from incus #12532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
force-pushed
the
import-from-incus
branch
from
ad44f37
to
21f6dc0
Compare
|
Can we keep GetMountinfo out of shared if possible as we want to slim that down to only stuff used by server and client |
Could you tell me where to put it? |
|
Yeah that sounds good |
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
force-pushed
the
import-from-incus
branch
2 times, most recently
from
122a710
to
4cc64e2
Compare
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
force-pushed
the
import-from-incus
branch
from
4cc64e2
to
30a77ed
Compare
tomponline
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes mainly:
lxc/incus#223
lxc/incus#225
I opted to put the new
GetMountinfo()function in thesharedpackage which felt like a good place but I wasn't 100% sure.