Few small changes to lxd-agent-setup script
#12552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…d set nodev,nosuid,noatime Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…p to avoid chown Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
MusicDin
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
My only question is why is tmpfs size reduced to 25M?
Otherwise, looks good to me. I've tested it locally with an ubuntu:22.04 image.
@simondeziel Once this is merged, could you also update this in https://github.com/canonical/lxd-agent-loader after the import source from LP PR is merged?
Cause we are only using ~14M so I figured we didn't need that much.
For sure! |
tomponline
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.