Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxc/move: Only use server-side move when dealing with a single server #12675

Merged
merged 1 commit into from
Jan 17, 2024
Merged

lxc/move: Only use server-side move when dealing with a single server #12675

merged 1 commit into from
Jan 17, 2024

Conversation

MusicDin
Copy link
Member

No description provided.

@stgraber @MusicDin
lxc/move: Only use server-side move when dealing with a single server
6df2cd0 
Contributed under Apache-2.0 License

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Din Music <din.music@canonical.com>
@tomponline
Copy link
Member

@MusicDin please can you include in this PR an update to the tests to catch this regression? Thanks

@stgraber
Copy link
Contributor

A kind reminder that the author of this change has not and will not sign the Canonical CLA which per https://github.com/canonical/lxd/blob/main/CONTRIBUTING.md#license-and-copyright is a requirement for all new contributions to this repository.

@escabo
Copy link
Contributor

escabo commented Jan 17, 2024

A kind reminder that the author of this change has not and will not sign the Canonical CLA which per https://github.com/canonical/lxd/blob/main/CONTRIBUTING.md#license-and-copyright is a requirement for all new contributions to this repository.

We have updated the CONTRIBUTING.md file to clarify and distinguish between new code contributions and importing code already published with a compatible license.

@tomponline tomponline merged commit 6dc565a into canonical:main Jan 17, 2024
25 of 26 checks passed
@MusicDin MusicDin deleted the bp/fix/server-side-move branch January 17, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MusicDin @tomponline @stgraber @escabo