-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes AGPL imports from shared package #12740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not used by client. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
This is not used by the client. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
This is not used by client. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
As not used by client. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
As not used by client. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
As used by shared. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
tomponline
force-pushed
the
tp-client-apache-2.0
branch
3 times, most recently
from
January 18, 2024 11:55
877eb93
to
c55d0a4
Compare
This just adds noise to the CI output. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit 5b360a85abe27f590aea1719cee4f32868ab9f99) Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> License: Apache-2.0 Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…censed packages As they are licensed out as Apache-2.0. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
tomponline
force-pushed
the
tp-client-apache-2.0
branch
from
January 18, 2024 12:05
c55d0a4
to
51267fc
Compare
tomponline
requested review from
MusicDin and
simondeziel
and removed request for
MusicDin
January 18, 2024 12:15
MusicDin
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the re-licensing of the
client
andshared
packages as Apache-2.0 in #12731@stgraber noticed that the
shared
package did import some packages from the AGPL 3.0 parts of the LXD codebase.This PR restructures those packages so that
client
andshared
only depends on Apache-2.0 parts of the LXD codebase.In general I have moved files that have LXD specific concepts in them into the
lxd
directory, even if they are used by non-LXD binaries (such aslxc
) because the CLI tools are still licensed as AGPL-3.0-only.I have moved the
revert
package intoshared
because it is not LXD specific and could be useful in theclient
package.Also adds a license check to CI to prevent a regression.