Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes AGPL imports from shared package #12740

Merged
merged 24 commits into from
Jan 18, 2024

Conversation

tomponline
Copy link
Member

@tomponline tomponline commented Jan 18, 2024

Following on from the re-licensing of the client and shared packages as Apache-2.0 in #12731

@stgraber noticed that the shared package did import some packages from the AGPL 3.0 parts of the LXD codebase.

This PR restructures those packages so that client and shared only depends on Apache-2.0 parts of the LXD codebase.

In general I have moved files that have LXD specific concepts in them into the lxd directory, even if they are used by non-LXD binaries (such as lxc) because the CLI tools are still licensed as AGPL-3.0-only.

I have moved the revert package into shared because it is not LXD specific and could be useful in the client package.

Also adds a license check to CI to prevent a regression.

This is not used by client.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
This is not used by the client.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
This is not used by client.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
As not used by client.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline self-assigned this Jan 18, 2024
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
As not used by client.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
As used by shared.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline force-pushed the tp-client-apache-2.0 branch 3 times, most recently from 877eb93 to c55d0a4 Compare January 18, 2024 11:55
tomponline and others added 3 commits January 18, 2024 12:05
This just adds noise to the CI output.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
(cherry picked from commit 5b360a85abe27f590aea1719cee4f32868ab9f99)
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
License: Apache-2.0
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…censed packages

As they are licensed out as Apache-2.0.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline marked this pull request as ready for review January 18, 2024 12:15
@tomponline tomponline requested review from MusicDin and simondeziel and removed request for MusicDin January 18, 2024 12:15
@tomponline tomponline merged commit 3f8e4f7 into canonical:main Jan 18, 2024
25 of 26 checks passed
@tomponline tomponline deleted the tp-client-apache-2.0 branch January 18, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants