Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: enable multiprocessing for pyspelling #12751

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

ru-fu
Copy link
Contributor

@ru-fu ru-fu commented Jan 19, 2024

Pyspelling has a new option to run jobs in parallel. This should make the spelling check considerably faster.

@ru-fu ru-fu requested a review from tomponline as a code owner January 19, 2024 16:52
@github-actions github-actions bot added the Documentation Documentation needs updating label Jan 19, 2024
tomponline
tomponline previously approved these changes Jan 19, 2024
@@ -1,3 +1,4 @@
jobs: 8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the example they used in their announcement. ;)
Does another value make more sense?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we maybe use something equivalent to $$nproc?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are using GH runners with 2 CPUs currently so 2 would probably be best.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MusicDin thats a good idea

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$$nproc

How do I get that in the config file?

@ru-fu
Copy link
Contributor Author

ru-fu commented Jan 19, 2024

Current time is around 6 mins.
With jobs: 8, it's 3.30.
Let's try with 2. ;)

Pyspelling has a new option to run jobs in parallel.
This should make the spelling check considerably faster.

Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
@tomponline
Copy link
Member

@ru-fu nice! does the docs build itself support a multi core mode?

@ru-fu
Copy link
Contributor Author

ru-fu commented Jan 19, 2024

3.50 with 2 jobs (could just be normal variation though)

@ru-fu nice! does the docs build itself support a multi core mode?

I don't know - I doubt it, otherwise someone would probably have suggested already to speed it up. 😉
But I can check next week.

@tomponline tomponline merged commit 91efd07 into canonical:main Jan 19, 2024
24 of 25 checks passed
@ru-fu ru-fu deleted the speed-up-spelling-check branch January 22, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants