Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Candid authentication and RBAC authorization #12830

Merged
merged 43 commits into from
Feb 7, 2024
Merged

Remove Candid authentication and RBAC authorization #12830

merged 43 commits into from
Feb 7, 2024

Conversation

markylaing
Copy link
Contributor

Removes Candid and RBAC from LXD, the LXD client, the CLI, the documentation, and all related tooling and tests.

@markylaing
lxd: Remove Candid from list of supported authentication methods.
524cd42 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxd: Remove Candid and RBAC from config update logic.
bea6638 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxd: Remove candid from http handlers.
e472cef 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxd: Remove Candid and RBAC from daemon init logic.
e862e34 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxd: Remove Candid verifier from daemon.
448e29c 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxd/auth/candid: Remove Candid verifier logic.
66aa584 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxd/auth: Remove RBAC authorization logic.
34087c2 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxd/cluster/config: Remove RBAC and Candid config keys.
d265053 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
Runs make update-metadata
3cdc4aa 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxd: Remove candid from swagger doc.
8c94b20 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
shared/api: Update swagger example authentication methods.
1003801 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
doc: Runs make update-api.
3a69738 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
client: Don't set macaroon fields when using a target or project.
0e8bffb 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
client: Do not use bakery client for HTTP requests.
f43bd71 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
client: Ignore candid auth type when connecting.
d5b55bc 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
client: Remove bakery client.
5969eaa 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing markylaing self-assigned this Feb 7, 2024
@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Feb 7, 2024
@markylaing
Copy link
Contributor Author

CLA check is failing because there are too many commits (I'll look into fixing this). In the meantime I can see that all of my commits are signed off with:

$ git log main..HEAD --oneline | wc -l
43
$ git log main..HEAD | grep 'Signed-off-by' | wc -l
43

tomponline
tomponline previously approved these changes Feb 7, 2024
View reviewed changes
@markylaing
lxd-migrate: Remove candid auth.
670f104 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxc/config: Remove candid from lxc remote helpers.
c121a10 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxc: Remove candid --auth-type from lxc remote add.
998d45e 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
test: Remove Candid and RBAC test suites.
412a639 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
test: Remove Candid and RBAC test helpers.
45773e9 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
test/suites: Remove candid reference from server config test.
c4c2216 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
gitignore: Remove rbac test helper.
59bc2b4 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
doc/howto: Replace candid with oidc in --auth-type example.
91f6a0b 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
doc/howto: Remove RBAC from projects confine howto.
3eaa480 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
doc/explanation: Remove RBAC from projects explanation.
aa45658 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
doc: Remove Candid and RBAC config options.
a1f677a 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
doc: Remove Candid and RBAC from authentication methods.
f8934b2 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
doc: Remove RBAC and Candid API extensions.
74bd131 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
doc: Remove RBAC from wordlist.
0ef2fc5 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
test: Remove Candid dependencies from allowed client imports.
194f4df 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxc/config: Fix lint error (revive: confusing-results).
fe5e210 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxd-migrate: Fix lint error (revive: receiver-naming).
fe6ed20 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxd-migrate: Fix lint error (revive: exported).
2a1e192 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxd-migrate: Ignore lint error (revive: deep-exit).
08afa76 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxd/auth: Ignore lint errors (revive: exported).
9f07fbf 
This file will soon be deleted/heavily modified to change
authorization object types into "entity types" and
authorization objects into URLs. New entitlements will also
be added. The nolint directive will be removed after the
changes are made.

Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxd/cluster/config: Fix lint errors (revive: confusing-results).
9357847 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing
lxc/remote: Fix lint errors (revive: exported).
a7d4f4a 
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@tomponline tomponline merged commit 59a5a74 into canonical:main Feb 7, 2024
25 of 26 checks passed
@markylaing
Copy link
Contributor Author

@tomponline apologies - I forgot the patch to remove the old config keys from the database. I'll put up a separate PR.

markylaing added a commit to markylaing/lxd that referenced this pull request Feb 8, 2024
@markylaing
lxd: Remove RBAC and Candid config keys (patch).
689b909 
canonical#12830 removed Candid and RBAC
support from LXD but the database entries for the config items in any
existing LXD installations that are using Candid/RBAC will remain. This
patch removes those config items.

Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing markylaing mentioned this pull request Feb 8, 2024
Merged
markylaing added a commit to markylaing/lxd that referenced this pull request Feb 8, 2024
@markylaing
lxd: Remove RBAC and Candid config keys (patch).
dc86600 
canonical#12830 removed Candid and RBAC
support from LXD but the database entries for the config items in any
existing LXD installations that are using Candid/RBAC will remain. This
patch removes those config items.

Signed-off-by: Mark Laing <mark.laing@canonical.com>
markylaing added a commit to markylaing/lxd that referenced this pull request Feb 8, 2024
@markylaing
lxd: Remove RBAC and Candid config keys (patch).
8ffff7b 
canonical#12830 removed Candid and RBAC
support from LXD but the database entries for the config items in any
existing LXD installations that are using Candid/RBAC will remain. This
patch removes those config items.

Signed-off-by: Mark Laing <mark.laing@canonical.com>
This was referenced Feb 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

@roosterfish roosterfish Awaiting requested review from roosterfish

@gabrielmougard gabrielmougard Awaiting requested review from gabrielmougard

@MusicDin MusicDin Awaiting requested review from MusicDin

Assignees

@markylaing markylaing

Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markylaing @tomponline