Update starterpack #13117
Merged
Update starterpack #13117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes canonical#13062 PR for the starter pack is open. Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
ru-fu
force-pushed
the
update-starterpack
branch
18 times, most recently
from
4be70cc to
febb8b3
Compare
Main changes for this version are: - Dynamic dependency management - Font changes to adhere more to Vanilla - Update tab style - Accessibility fixes - Nicer 404 page Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Manually install gitpython, because it must be available to generate the requirements.txt file, which is before the venv is created. Issue for this is here: canonical/sphinx-docs-starter-pack#197 Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
ru-fu
force-pushed
the
update-starterpack
branch
from
febb8b3 to
5db8be4
Compare
tomponline
approved these changes
Mar 13, 2024
Thanks! |
tomponline
reviewed
Mar 13, 2024
| @@ -131,6 +131,7 @@ update-metadata: build | |||
| .PHONY: doc-setup | |||
| doc-setup: client | |||
| @echo "Setting up documentation build environment" | |||
| pip3 install gitpython pyyaml | |||
There was a problem hiding this comment.
Could this be done just after line 136 so its installed in the venv and not globally?
There was a problem hiding this comment.
Hmm, not sure. It might work ... can't test it locally though because it works on my machine anyway. ;)
Let's try it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the starter pack to the current version, and fix the link colour for dark mode.
Fixes #13062
Fixes #12244